Skip to content

Don't require the element to be provided to percolate_down! and percolate_up! #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 5 commits into from
Nov 4, 2025
Merged

Don't require the element to be provided to percolate_down! and percolate_up! #960

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad1fe9e
Don't require the element to be provided to `percolate_down!`
Drvi Nov 4, 2025
4c87c8a
Also fix percolate_up!
Drvi Nov 4, 2025
73e123a
Add tests
Drvi Nov 4, 2025
e5c27c4
Add changelog entry
Drvi Nov 4, 2025
083d5c7
v0.19.3
Drvi Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/heaps/arrays_as_heaps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Base.@propagate_inbounds function percolate_down!(xs::AbstractArray, i::Integer,
end
@inbounds xs[i] = x
end
Base.@propagate_inbounds percolate_down!(xs::AbstractArray, i::Integer, o::Ordering, len::Integer=length(xs)) = percolate_down!(xs, i, xs[i], o, len)
Base.@propagate_inbounds percolate_down!(xs::AbstractArray, i::Integer, o::Ordering=Forward, len::Integer=length(xs)) = percolate_down!(xs, i, xs[i], o, len)


# Binary min-heap percolate up.
Expand All @@ -41,7 +41,7 @@ Base.@propagate_inbounds function percolate_up!(xs::AbstractArray, i::Integer, x
end
@inbounds xs[i] = x
end
Base.@propagate_inbounds percolate_up!(xs::AbstractArray, i::Integer, o::Ordering) = percolate_up!(xs, i, xs[i], o)
Base.@propagate_inbounds percolate_up!(xs::AbstractArray, i::Integer, o::Ordering=Forward) = percolate_up!(xs, i, xs[i], o)

"""
heappop!(v, [ord])
Expand Down
Loading