-
Notifications
You must be signed in to change notification settings - Fork 2
Invalidate caches on refresh()
#24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate caches on refresh()
#24
Conversation
|
This requires JuliaLang/julia#58324 to avoid a crash during invalidation. |
ffcb4b2 to
620f9f1
Compare
620f9f1 to
64bcf7c
Compare
|
Tests now pass locally. I'm thinking that instead of passing |
Yes, I suggested this in one of the review comments (#24 (comment)) |
|
Indeed, I just wanted to confirm you weren't only talking about that specific case 👍 |
I am not sure when we may be in the situation where `edges` is `null`, but if we do, we crash. I triggered such a crash in JuliaComputing/DAECompiler.jl#24, which manually adds edges to handcrafted code instances. I may be doing something wrong, but in any case, it doesn't hurt to be more robust (and perhaps handle this situation more gracefully). --------- Co-authored-by: Jameson Nash <[email protected]>
…date-caches-on-refresh
|
Tests are passing, this is good for final review & merge. |
…ang#58324) I am not sure when we may be in the situation where `edges` is `null`, but if we do, we crash. I triggered such a crash in JuliaComputing/DAECompiler.jl#24, which manually adds edges to handcrafted code instances. I may be doing something wrong, but in any case, it doesn't hurt to be more robust (and perhaps handle this situation more gracefully). --------- Co-authored-by: Jameson Nash <[email protected]>
Implements #20.
Tests don't all pass at the moment, it seems that only code instances with
StructureCache()andADCache()as owners get invalidated:which I can believe might be due to the other keys not being singletons, which may surface a bug - as currently implemented edges should be identical across all owners, except maybe
ADCache().