WIP: Add IPO-friendly version of thermal fluid benchmark #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
reviewed
May 12, 2025
| end | ||
|
|
||
| always!(ddt(Tn[1]) * Cn[1] - (inner_heatport.Q - Qe[1])) | ||
| ntuple(Nn-2) do j |
Member
There was a problem hiding this comment.
Does this work now? When I tried this, I quickly ran into the manual unroll limit of ~15 in Base
Member
Author
There was a problem hiding this comment.
Nn is 3 ;). There is another N-3 ntuple below, but that'll need to be replaced with some log-tree generated function anyway - I'll cross that bridge when we get there.
Make structural analysis of benchmark pass WIP Get benchmark through codegen
Member
Author
|
It's crashing when you actually try to run it, but it does make it all the way through codegen, so I think it's a good integration test, so I'm planning to merge and keep looking at the crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully complete, but hopefully good enough to start playing with