Add thread-through state to all partitions #36
Merged
+218
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the ABI of our scheduled functions to return tuples of the requested equation residuals and some thread-through state (these are basically the same as the optic residuals in Diffractor, but I'm avoiding using the terms residuals, because that already has three meanings in DAECompiler). This temporarily somewhat regresses SICM quality, but we need to do some further work to properly integrate SICM with our initialization system, and I'd like to wait with restoring SICM quality until that is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the ABI of our scheduled functions to return tuples of the requested equation residuals and some thread-through state (these are basically the same as the optic residuals in Diffractor, but I'm avoiding using the terms residuals, because that already has three meanings in DAECompiler). This temporarily somewhat regresses SICM quality, but we need to do some further work to properly integrate SICM with our initialization system, and I'd like to wait with restoring SICM quality until that is done.