-
Notifications
You must be signed in to change notification settings - Fork 2
Add Cthulhu
integration using the new provider API
#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
test/runtests.jl
Outdated
include("errors.jl") | ||
include("invalidation.jl") | ||
include("validation.jl") | ||
include("cthulhu.jl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually the include
that I forgot to remove. I planned to have tests (and still do), but until now I've just tested manually.
Labeling for the descend seems wrong:
Is this what you meant by |
Could I get an extra |
Yes, exactly. Until this is fixed, it's probably best to switch to typed view when introspecting. |
@Keno would it be possible to update the dependencies on |
Uses the new API introduced in JuliaDebug/Cthulhu.jl#662 to enable an integration with Cthulhu, allowing to navigate with
descend
into the post-structuralCodeInstance
s we generate. This facilitates introspection into the refined lattice elements that we introduce (e.g.Eq
,Incidence
) which appear in type annotations.To do:
variable
, etc), which otherwise error when descending into them (requires an interface in Cthulhu to filter out callsites).