Skip to content

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented May 9, 2025

Companion for #42, which attempts, in detail, to document the current ("classic") authentication flow. It's a non-standard flow, so currently the implementation here effectively is the specification of the flow (for anyone who would like to implement their own authenticated package server).

The device token docs from #42 could nicely be added to the end of the file.

@mortenpi mortenpi requested review from nkottary and tanmaykm May 9, 2025 07:51
mortenpi and others added 2 commits May 12, 2025 11:40
Co-authored-by: Nishanth H. Kottary <[email protected]>
Co-authored-by: Tanmay Mohapatra <[email protected]>
Copy link
Member

@tanmaykm tanmaykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition. We should add a section with details from #42.

@tanmaykm
Copy link
Member

It will be good to have the Pkg protocol documented. It is somewhat fragmented across multiple PRs now, which is hard to browse and can be sometimes confusing because of changes done over time. I had collated those into one rough consolidated doc sometime back... will put up a separate PR with that in a bit to iterate on and possibly add that as well.

@mortenpi
Copy link
Member Author

will put up a separate PR with that in a bit to iterate on and possibly add that as well.

I think that should be a PR to Pkg.jl. It's a bit of out of scope for this package. In fairness, also some of the things from this PR should actually be documented there (the assumptions around auth.toml files).

@tanmaykm
Copy link
Member

tanmaykm commented May 12, 2025

Yes, makes sense. I'll make it to Pkg.jl...


Update: JuliaLang/Pkg.jl#4234

@mortenpi mortenpi requested a review from pfitzseb May 12, 2025 08:14
@mortenpi mortenpi merged commit 4fb736c into master May 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants