chore: impose JuliaFormatter on the codebase #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts on using Runic instead? :) |
|
We use JuliaFormatter elsewhere though, and I think it's better to be consistent, as not to make us depend on too many different tools that do the same thing. Also, Runic is not yet integrated into the extension, right? So you still can't easily "dispatch" between the two right now? |
|
One note: it does impose JuliaFormatter v1, which is also not great. But that's also consistent. But we should probably at least bump everything to v2 at some point. |
pfitzseb
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the standard
.JuliaFormatter.toml(copied from JuliaHub.jl). Motivated by #48 (cc @thelonewolf1603).