Skip to content

widen the scope of ss*mat method #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

widen the scope of ss*mat method #949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d560bf
widen the scope of ss*mat method
baggepinnen Jan 10, 2025
8e9aeae
remove unbound type param
baggepinnen Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ControlSystemsBase/src/types/StateSpace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,8 @@ function Base.Broadcast.broadcasted(::typeof(*), M::AbstractArray{<:Number}, sys
sminreal(basetype(ST)(Ae, Be, Ce, De, sys1.timeevol))
end

function *(sys1::ST, D::Diagonal) where {ST <: AbstractStateSpace}
if issiso(sys1) # This is a special case that falls back on broadcasting
function *(sys1::AbstractStateSpace, D::AbstractMatrix)
if issiso(sys1) && isdiag(D) # This is a special case that falls back on broadcasting
return sys1 .* D
else # This is the standard implementation but must be handled here since we special case diagonal matrices for the case above
sys1 * ss(D, sys1.timeevol)
Expand Down
Loading