Skip to content

Bump ImplicitDifferentiation bound + run CompatHelper on subpackages #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

Bump ImplicitDifferentiation bound + run CompatHelper on subpackages #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ecd282
Run CompatHelper on subpackages
gdalle Apr 11, 2025
6b2d515
Bump
gdalle Apr 15, 2025
0b71c79
Fix vector
gdalle Apr 15, 2025
96e6a4d
Fix return
gdalle Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CompatHelper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: "Run CompatHelper"
run: |
import CompatHelper
CompatHelper.main()
CompatHelper.main(; subdirs=["", "lib/ControlSystemsBase"])
shell: julia --color=yes {0}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion lib/ControlSystemsBase/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ControlSystemsBaseImplicitDifferentiationExt = ["ImplicitDifferentiation", "Comp
Aqua = "0.5"
DSP = "0.6.1, 0.7, 0.8"
ForwardDiff = "0.10"
ImplicitDifferentiation = "0.4.2"
ImplicitDifferentiation = "0.7.2"
LinearAlgebra = "<0.0.1, 1"
MacroTools = "0.5"
MatrixEquations = "1, 2.1"
Expand Down
11 changes: 6 additions & 5 deletions lib/ControlSystemsBase/ext/ControlSystemsBaseImplicitDifferentiationExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,12 @@ import ControlSystemsBase: hinfnorm
function forward_hinfnorm(pars; kwargs...)
(; A,B,C,D) = pars
sys = ss(A,B,C,D)
hinfnorm(sys; kwargs...)
γ, w = hinfnorm(sys; kwargs...)
return [γ], w
end

function conditions_hinfnorm(pars, γ, w; tol=1e-10)
function conditions_hinfnorm(pars, γ_vec, w; tol=1e-10)
γ = only(γ_vec)
(; A,B,C,D) = pars
sys = ss(A,B,C,D)
[opnorm(freqresp(sys, w)) - γ]
Expand All @@ -222,8 +224,8 @@ A reverse-differentiation rule is defined in RobustAndOptimalControl.jl, which m
function hinfnorm(sys::StateSpace{Continuous, <:Dual}; kwargs...)
A,B,C,D = ssdata(sys)
pars = ComponentVector(; A,B,C,D)
γ, w = implicit_hinfnorm(pars)
γ, w
γ_vec, w = implicit_hinfnorm(pars)
only(γ_vec), w
end


Expand Down Expand Up @@ -264,4 +266,3 @@ end


end # module

Loading