Skip to content

fix hover with adaptive sampling nyquist plot #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix hover with adaptive sampling nyquist plot #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ControlSystemsBase/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "ControlSystemsBase"
uuid = "aaaaaaaa-a6ca-5380-bf3e-84a91bcd477e"
authors = ["Dept. Automatic Control, Lund University"]
repo = "https://github.com/JuliaControl/ControlSystems.jl.git"
version = "1.16.0"
version = "1.16.1"

[deps]
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
Expand Down
4 changes: 3 additions & 1 deletion lib/ControlSystemsBase/src/plotting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,13 +452,15 @@ nyquistplot
if lab !== nothing
label --> lab
end
hover --> [hz ? Printf.@sprintf("f = %.3g", w/2π) : Printf.@sprintf("ω = %.3g", w) for w in w]
hover_data = [hz ? Printf.@sprintf("f = %.3g", w/2π) : Printf.@sprintf("ω = %.3g", w) for w in w]
if adaptive
indsre = downsample(w, redata, 1/500)[3]
indsim = downsample(w, imdata, 1/500)[3]
inds = sort!(union(indsre, indsim))
hover --> hover_data[inds]
redata[inds], imdata[inds]
else
hover --> hover_data
redata, imdata
end
end
Expand Down
Loading