changed: @error instead of @warn in MHE arrival covariance fallback + update CI#154
changed: @error instead of @warn in MHE arrival covariance fallback + update CI#154franckgaga merged 6 commits intomainfrom
@error instead of @warn in MHE arrival covariance fallback + update CI#154Conversation
…riance following the "convention" throughout the package, a non fatal `@error` make more sense. It's similar to unfeasible MPC problem : something is wrong but there is a fallback: take the solution from the last time step
@error instead of @warn in MHE fallback for arrival covariance@error instead of @warn in MHE fallback for arrival covariance and update CI
@error instead of @warn in MHE fallback for arrival covariance and update CI@error instead of @warn in MHE arrival covariance fallback + update CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 24 24
Lines 3800 3800
=======================================
Hits 3758 3758
Misses 42 42 ☔ View full report in Codecov by Sentry. |
|
FYI @baggepinnen Might be worth it to update the The interesting parts would be to update to runs-on: ${{ matrix.os }} # new part just after this line:
permissions: # needed for julia-actions/cache delete old caches that it has created
actions: write
contents: readWith v2 of matrix:
version:
- 'lts' # long-term support release
- '1' # latest stable 1.x release
- 'pre' # latest stable prerelease
# - 'nightly' # commented since noisy + 'pre' allows testing upcoming versionsIMO it covers large enough to see major issues for Julia version incompatibilities. |
Following the "convention" throughout the package, a non fatal
@errorlog make more sense than@warn.It's similar to
@erroremitted by an unfeasible MPC problem: something is wrong but there is a fallback. That is, take the solution from the last time step.Also updated the
CI.ymlwith new feature like improved speed with cache v2 and replacing Julia nightly bypretesting.