debug: fallback if nonfinite arr. cov. after correction/update#156
Merged
franckgaga merged 1 commit intomainfrom Feb 6, 2025
Merged
debug: fallback if nonfinite arr. cov. after correction/update#156franckgaga merged 1 commit intomainfrom
franckgaga merged 1 commit intomainfrom
Conversation
The fallback is still relevant if new `NaN` or `Inf` values appear in the covariance arrival. A different message is print tho to help troubleshooting. As mentioned by @baggepinnen, it may be caused by a different issue, like a sudden NaN values in the measurements `ym`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 24 24
Lines 3800 3806 +6
=======================================
+ Hits 3758 3764 +6
Misses 42 42 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback is still relevant if new
NaNorInfvalues appear in the covariance arrival. It just happened in CI (a NaN value was produced by thecholeskycalls)A different message is print tho to help troubleshooting. Since as mentioned by @baggepinnen, it may be caused by a different issue, like a sudden NaN values in the measurements
ym.