Skip to content

debug: NonLinModel fields are now all concrete types#161

Merged
franckgaga merged 2 commits intomainfrom
debug_ti_nonlinmodel
Feb 18, 2025
Merged

debug: NonLinModel fields are now all concrete types#161
franckgaga merged 2 commits intomainfrom
debug_ti_nonlinmodel

Conversation

@franckgaga
Copy link
Copy Markdown
Member

Not proud of this but I forgot to remove a struct parameter in SimModelBuffer in last release. As a result, the buffer field in NonLinModel was an abstract type, instead of a fully defined concrete type, as it should be.

Yep similar mistake as before! 😢

I need to find the time to implement some JET.jl tests for type stability and such.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (2b1abf0) to head (06c65e0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   98.57%   99.01%   +0.44%     
==========================================
  Files          24       24              
  Lines        3787     3770      -17     
==========================================
  Hits         3733     3733              
+ Misses         54       37      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franckgaga franckgaga merged commit 2e7ab0e into main Feb 18, 2025
4 checks passed
@franckgaga franckgaga deleted the debug_ti_nonlinmodel branch February 18, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants