Skip to content

fixed bug with empty constructors #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fixed bug with empty constructors #86

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
004d0e3
fixed bug with empty constructors
kragol Jul 28, 2023
086df6c
added tests for empty constructors
kragol Jul 28, 2023
c92e61b
Update test/runtests.jl
bkamins Jul 28, 2023
e53664c
Update test/runtests.jl
bkamins Jul 28, 2023
fe23cfd
Update test/runtests.jl
bkamins Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/PooledArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ end
PooledArray{T}(d, signed=signed, compress=compress)

# Construct an empty PooledVector of a specific type
@inline PooledArray(t::Type) = PooledArray(Array(t,0))
@inline PooledArray(t::Type, r::Type) = PooledArray(Array(t,0), r)
@inline PooledArray(t::Type) = PooledArray(Array{t}(undef,0))
@inline PooledArray(t::Type, r::Type) = PooledArray(Array{t}(undef,0), r)

##############################################################################
##
Expand Down
3 changes: 3 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ end
@testset "PooledArrays" begin
@test eltype(PooledArray(Int[])) === Int

@test PooledArray(Int) == Int[]
@test PooledArray(Int,UInt64) == Int[]

a = rand(10)
b = rand(10,10)
c = rand(1:10, 1000)
Expand Down