Change getrows -> subset #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a generic implementation of subset for column-oriented tables and row-oriented tables that are AbstractVector. Adds implementation and tests for DictRowTable/DictColumnTable.
Merged
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 94.94% 95.08% +0.13%
==========================================
Files 7 7
Lines 673 692 +19
==========================================
+ Hits 639 658 +19
Misses 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bkamins
reviewed
Sep 6, 2022
bkamins
reviewed
Sep 6, 2022
| return ColumnsRow(cols, inds) | ||
| else | ||
| ret = view === true ? _map(c -> Base.view(c, inds), cols) : _map(c -> c[inds], cols) | ||
| return DictColumnTable(schema(cols), ret) |
There was a problem hiding this comment.
As a special case someone can pass CartesianIndex as inds - do we want to handle it in the ColumnsRow case or error on it here?
bkamins
reviewed
Sep 6, 2022
| return DictRow(x.names, x.values[st]), st + 1 | ||
| end | ||
|
|
||
| function subset(x::DictRowTable, inds; view::Union{Bool,Nothing} = nothing) |
There was a problem hiding this comment.
similar comments as above to inds apply here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a generic implementation of subset for column-oriented tables
and row-oriented tables that are AbstractVector. Adds implementation and
tests for DictRowTable/DictColumnTable.