Remove outdated version checks #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not strictly needed, but as we are already dropping support for Cthulhu there is no need to maintain backwards compatibility with version checks so it's easier to remove them
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #630 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 11
Lines ? 1535
Branches ? 0
======================================
Hits ? 0
Misses ? 1535
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Looking at the warnings, I suspect the IntegrationTest job may be failing because JET does not yet support 1.12. As the update shouldn't be too far out, I think we can keep it just to make sure the error remains the same (and is not triggered by a failed precompilation of CthulhuExt for example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are removing support for Julia versions < 1.12 starting from the 2.17 release, we can remove all version checks that may be optimized away assuming
VERSION >= v"1.12-".