Backport: Adjust to .result -> .optresult change for OptimizationState

[serenity4]

Backports #634 to have the fix for #633 on master

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2c33b9a) to head (c216d93).
Report is 51 commits behind head on master.

Files with missing lines	Patch %	Lines
src/interpreter.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #635   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9      11    +2     
  Lines        1556    1644   +88     
======================================
- Misses       1556    1644   +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[aviatesk]

Since users on Julia 1.12 or later will be using the 2.17 series, don't we need to add compatibility for Julia 1.12+ code to the 2.16 series?

[serenity4]

Correct, but since the breaking PR was for 1.13, so long as it's not backported there is nothing more to do.

[serenity4]

don't we need to add compatibility for Julia 1.12+ code to the 2.16 series?

Or did you say we don't need to add the code to the 2.16 series? That's true, it's not the first time I am confused about having 2.17 as a separate branch but having it available to 1.12 still 🫠

[aviatesk]

Yeah, this is the first time we're doing things this way, and it turns out to be a bit complicated.
How about we flip the current setup? We manage 2.17 in the master branch, and the 2.16 series in the 2.16 branch, since we'll be making a lot of changes to 2.17, but probably hardly any to 2.16.

[serenity4]

Yes, that's a good idea.

[aviatesk]

Or did you say we don't need to add the code to the 2.16 series?

Yeah, basically we just do "bug fix" only for the 2.16 series. If some destructive change is backported to Julia 1.11 series, we may need to apply some big changes to the 2.16 series, but otherwise we won't add much changes to 2.16.