Skip to content

use consistent preferences when the extension code is used #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviatesk merged 1 commit into from
Jun 26, 2025
Merged

use consistent preferences when the extension code is used #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions src/preferences.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ julia> Cthulhu.save_config!(Cthulhu.CONFIG) # Will be automatically read next ti
```
"""
function save_config!(config::CthulhuConfig=CONFIG)
@set_preferences!(
set_preferences!(Cthulhu,
"enable_highlighter" => config.enable_highlighter,
"highlighter" => config.highlighter.exec,
"asm_syntax" => String(config.asm_syntax),
Expand All @@ -36,24 +36,23 @@ function save_config!(config::CthulhuConfig=CONFIG)
"annotate_source" => config.annotate_source,
"inlay_types_vscode" => config.inlay_types_vscode,
"diagnostics_vscode" => config.diagnostics_vscode,
"jump_always" => config.jump_always,
)
"jump_always" => config.jump_always)
end

function read_config!(config::CthulhuConfig)
config.enable_highlighter = @load_preference("enable_highlighter", config.enable_highlighter)
config.highlighter = Cmd(@load_preference("highlighter", config.highlighter))
config.asm_syntax = Symbol(@load_preference("asm_syntax", config.asm_syntax))
config.pretty_ast = @load_preference("pretty_ast", config.pretty_ast)
config.debuginfo = Symbol(@load_preference("debuginfo", config.debuginfo))
config.optimize = @load_preference("optimize", config.optimize)
config.iswarn = @load_preference("iswarn", config.iswarn)
config.remarks = @load_preference("remarks", config.remarks)
config.with_effects = @load_preference("with_effects", config.with_effects)
config.inline_cost = @load_preference("inline_cost", config.inline_cost)
config.type_annotations = @load_preference("type_annotations", config.type_annotations)
config.annotate_source = @load_preference("annotate_source", config.annotate_source)
config.inlay_types_vscode = @load_preference("inlay_types_vscode", config.inlay_types_vscode)
config.diagnostics_vscode = @load_preference("diagnostics_vscode", config.diagnostics_vscode)
config.jump_always = @load_preference("jump_always", config.jump_always)
config.enable_highlighter = load_preference(Cthulhu, "enable_highlighter", config.enable_highlighter)
config.highlighter = Cmd(load_preference(Cthulhu, "highlighter", config.highlighter))
config.asm_syntax = Symbol(load_preference(Cthulhu, "asm_syntax", config.asm_syntax))
config.pretty_ast = load_preference(Cthulhu, "pretty_ast", config.pretty_ast)
config.debuginfo = Symbol(load_preference(Cthulhu, "debuginfo", config.debuginfo))
config.optimize = load_preference(Cthulhu, "optimize", config.optimize)
config.iswarn = load_preference(Cthulhu, "iswarn", config.iswarn)
config.remarks = load_preference(Cthulhu, "remarks", config.remarks)
config.with_effects = load_preference(Cthulhu, "with_effects", config.with_effects)
config.inline_cost = load_preference(Cthulhu, "inline_cost", config.inline_cost)
config.type_annotations = load_preference(Cthulhu, "type_annotations", config.type_annotations)
config.annotate_source = load_preference(Cthulhu, "annotate_source", config.annotate_source)
config.inlay_types_vscode = load_preference(Cthulhu, "inlay_types_vscode", config.inlay_types_vscode)
config.diagnostics_vscode = load_preference(Cthulhu, "diagnostics_vscode", config.diagnostics_vscode)
config.jump_always = load_preference(Cthulhu, "jump_always", config.jump_always)
end
Loading