Conversation
PR #654 restricted the types allowed to get "through" `treelist!`. While that got the Cthulhu tests working, it broke the intent of the extension API. This restores the original implementation, making changes elsewhere to compensate for the changes in the types of objects that Julia now uses.
serenity4
reviewed
Aug 30, 2025
serenity4
approved these changes
Aug 30, 2025
Collaborator
serenity4
left a comment
serenity4
left a comment
There was a problem hiding this comment.
That looks very reasonable to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #654 restricted the types allowed to get "through"
treelist!. While that got the Cthulhu tests working, it broke the intent of the extension API (which is used by SnoopCompile, ProfileView, and perhaps others). This restores the originaltreelist!implementation, making changes elsewhere to compensate for the changes in the types of objects that Julia now uses.@serenity4, are these changes OK, or might this break something else?
Note I made a couple of changes to the tests themselves, to allow despecialized or specialized variants of the same calls. This appears to be necessary to get nightly to pass (even on
Cthulhu#master).This, together with
SnoopCompile#teh/cthulhu, is almost enough to get the SnoopCompile extension test working. However, we still need a resolution to #619 (comment) (it works if I delete the[extensions]section of Cthulhu'sProject.toml).