Skip to content

Fix print_response hanging on 1.11.5+ #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 3 commits into from
Apr 18, 2025
Merged

Fix print_response hanging on 1.11.5+ #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17c622b
Fix print_response hanging on 1.11.5+
IanButterworth Apr 18, 2025
5585d60
use spawn. add comment
IanButterworth Apr 18, 2025
4e511cb
Update CI.yml
KristofferC Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v4
env:
cache-name: cache-artifacts
with:
Expand Down
10 changes: 7 additions & 3 deletions src/repl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,15 @@ function julia_prompt(state::DebuggerState)
return false
end
command = String(take!(buf))
@static if VERSION >= v"1.2.0-DEV.253"
response = _eval_code(active_frame(state), command)
response = _eval_code(active_frame(state), command)
@static if VERSION >= v"1.11.5"
# Since https://github.com/JuliaLang/julia/pull/57773 REPL.print_resons runs `display` on the backend
# task. If this is called from the same thread the channel orchestration will block, so do this async.
fetch(Threads.@spawn REPL.print_response(state.repl, response, true, true))
elseif VERSION >= v"1.2.0-DEV.253"
REPL.print_response(state.repl, response, true, true)
else
ok, result = _eval_code(active_frame(state), command)
ok, result = response
REPL.print_response(state.repl, ok ? result : result[1], ok ? nothing : result[2], true, true)
end
println(state.terminal)
Expand Down
Loading