Skip to content

Add global qualifier to inserted globals#131

Merged
pfitzseb merged 1 commit intoJuliaDebug:masterfrom
serenity4:fix-global-assignment
Feb 13, 2025
Merged

Add global qualifier to inserted globals#131
pfitzseb merged 1 commit intoJuliaDebug:masterfrom
serenity4:fix-global-assignment

Conversation

@serenity4
Copy link
Copy Markdown
Contributor

Disambiguates global assignments that used to be allowed but that no longer are after JuliaLang/julia#57253.

It makes this error go away on nightly:

julia> using Infiltrator

julia> @infiltrate
Infiltrating top-level frame

ERROR: invalid assignment to constant anonymous.@__MODULE__. This redefinition may be permitted using the `const` keyword.
Stacktrace:
 [1] top-level scope
   @ none:1
 [2] eval(m::Module, e::Any)
   @ Core ./boot.jl:488
 [3] init_transient_eval_module(mod::Module, locals::Dict{Symbol, Any})
   @ Infiltrator ~/julia/wip3/.julia/dev/Infiltrator/src/Infiltrator.jl:533

@serenity4
Copy link
Copy Markdown
Contributor Author

Seems like tests were failing for 1.11 before this PR: https://github.com/JuliaDebug/Infiltrator.jl/actions/runs/12650638097/job/35249552745

but the failure cancels tests for all other versions. Feel free to merge as is (if you are confident with the change) or to proceed with selectively running/fixing tests as you prefer.

@pfitzseb
Copy link
Copy Markdown
Member

Thanks. I'll merge this as-is and figure out the 1.11 test failure later...

@pfitzseb pfitzseb merged commit b01991a into JuliaDebug:master Feb 13, 2025
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants