Adjust print_response workaround to minor REPL refactor#145
Merged
pfitzseb merged 3 commits intoJuliaDebug:masterfrom May 20, 2025
Merged
Adjust print_response workaround to minor REPL refactor#145pfitzseb merged 3 commits intoJuliaDebug:masterfrom
print_response workaround to minor REPL refactor#145pfitzseb merged 3 commits intoJuliaDebug:masterfrom
Conversation
…into call-on-backend-fix
Contributor
Author
|
Not sure why the tests for 1.12 are failing, I can't replicate locally on 1.12.0-beta3 (same as CI). It should not be affected by these changes. |
Member
|
No idea, seems to have been spurious. Tests pass locally as well. |
pfitzseb
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workaround introduced in #139 broke with JuliaLang/julia#58414.
It would be nice to have a more reliable way to do it, but for now we can just hope it breaks very rarely.