implement a system for interpreting overlay methods #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added a commit
that referenced
this pull request
Apr 20, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
added a commit
that referenced
this pull request
Apr 21, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
added a commit
that referenced
this pull request
Apr 21, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
added a commit
that referenced
this pull request
Apr 21, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
added a commit
that referenced
this pull request
Apr 21, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
force-pushed
the
avi/interpret-overlay
branch
3 times, most recently
from
967b925 to
da34141
Compare
Member
Author
|
This is now built on top of #683. |
aviatesk
added a commit
that referenced
this pull request
Apr 22, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
force-pushed
the
avi/interp-interface
branch
from
d662e72 to
b6d255c
Compare
aviatesk
added a commit
that referenced
this pull request
Apr 22, 2025
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
aviatesk
force-pushed
the
avi/interp-interface
branch
from
b6d255c to
eaf72f0
Compare
aviatesk
added a commit
that referenced
this pull request
Apr 23, 2025
#683) Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET. - allow specifying interpreter with `@interpret` - better error handling for `@interpret` - better `native_call` implementation - make `lookup` overloadable - define `NonRecursiveInterpreter` and make `Compiled` alias to it `Compiled` is preserved for backward compatibility. --------- Co-authored-by: Cédric Belmant <[email protected]>
Align the `recurse` argument to something like the base Compiler's `AbstractInterpreter` and make JuliaInterpreter routines overloadable properly. This change is quite breaking (thus bumping the minor version of this package), but necessary to enhance the customizability of JI. For example, it will make it easier to add changes like #682 in a nicer way, but also should enable better designs in packages such as Revise and JET.
Implemented, being inspired by #680, thinking it might be useful in the near future for JET's use case. The overlay interpretertation is enabled by overloading `JuliaInterpreter.method_table(recurse)`, but maybe the entire `recurse`-overload mechanism itself needs to be aligned with the `AbstractInterpreter` design and properly organized. Since this interface will also be needed for JET, I'll probably work on it soon.
aviatesk
force-pushed
the
avi/interpret-overlay
branch
from
da34141 to
1238d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented, being inspired by #680, thinking it might be useful in the near future for JET's use case.
The overlay interpretertation is enabled by overloading
JuliaInterpreter.method_table(recurse), but maybe the entirerecurse-overload mechanism itself needs to be aligned with theAbstractInterpreterdesign and properly organized.Since this interface will also be needed for JET,
I'll probably work on it soon.