fix: check isdefinedglobal before getglobal in lookup_stmt
#706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `lookup_stmt` encounters a `Base.getproperty` call pattern (used for llvmcall detection) it attempts to resolve intermediate `GlobalRef`s. Previously, it called `getglobal` without checking if the global was actually defined, causing `UndefVarError` when processing code in modules where the referenced global doesn't exist. This is problematic for tools like JET that analyze code in virtual modules where globals may not be necessarily defined. The fix adds an `isdefinedglobal` check before calling `getglobal`, consistent with the existing check at lines 27-28 for the final property lookup.
pfitzseb
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
lookup_stmtencounters aBase.getpropertycall pattern (used for llvmcall detection) it attempts to resolve intermediateGlobalRefs. Previously, it calledgetglobalwithout checking if the global was actually defined, causingUndefVarErrorwhen processing code in modules where the referenced global doesn't exist.This is problematic for tools like JET that analyze code in virtual modules where globals may not be necessarily defined.
The fix adds an
isdefinedglobalcheck before callinggetglobal, consistent with the existing check at lines 27-28 for the final property lookup.