Skip to content

fix AD demos on Julia nightly #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021
Merged

fix AD demos on Julia nightly #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d90ab6
fix AD demos on Julia nightly
simeonschaub Feb 8, 2021
df97168
bump patch version
simeonschaub Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRulesCore"
uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
version = "0.9.27"
version = "0.9.28"

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Expand Down
2 changes: 1 addition & 1 deletion test/demos/forwarddiffzero.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function define_dual_overload(sig)
opT, argTs = Iterators.peel(sig.parameters)
opT isa Type{<:Type} && return # not handling constructors
fieldcount(opT) == 0 || return # not handling functors
all(Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops.
all(argT isa Type && Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops.

N = length(sig.parameters) - 1 # skip the op
fdef = quote
Expand Down
2 changes: 1 addition & 1 deletion test/demos/reversediffzero.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function define_tracked_overload(sig)
opT, argTs = Iterators.peel(sig.parameters)
opT isa Type{<:Type} && return # not handling constructors
fieldcount(opT) == 0 || return # not handling functors
all(Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops.
all(argT isa Type && Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops.

N = length(sig.parameters) - 1 # skip the op
fdef = quote
Expand Down