Skip to content

WIP: add whitespace check #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: add whitespace check #463

wants to merge 1 commit into from

Conversation

simeonschaub
Copy link
Member

No description provided.

@simeonschaub simeonschaub force-pushed the sds/whitespace-check branch 2 times, most recently from 143b059 to 066711e Compare September 21, 2021 21:44
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (bdb52bb) to head (6cbe567).
⚠️ Report is 268 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          14       14           
  Lines         812      812           
=======================================
  Hits          755      755           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oxinabox
Copy link
Member

Rather than a check which can fail, can we use the reviewdog action to insert a review suggestion for how to fix?
That way do not have to change from the screen where it fails back the my editor.

@simeonschaub
Copy link
Member Author

I'll look into that, once I figured out the other issues.

@st--
Copy link
Contributor

st-- commented Oct 6, 2021

@simeonschaub: in case you hadn't spotted it in the related issue yet, #462 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants