add Unthunk #64
Merged
add Unthunk #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Let's do this |
fix extra comma
Member
Author
|
I am going to 0.5-DEV |
YingboMa
pushed a commit
to YingboMa/ChainRulesCore.jl
that referenced
this pull request
Dec 21, 2019
* add rules for complex util functions * fix accidentally deleted line * fix test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps
externforunthunkwhich just removes a layer of thunking,
rather than attempting to fully get from a differential to a primal
It is needed for #61 but is distrinct (that PR currently sits ontop of this one though)
Note that even in double thunking cases:
1+@thunk(@thunk(2))becomes1 + @thunk(2)becomes1+2so addition is still fine.
This also occurs in #54