Skip to content

Eagerly evaluate ::Zero * ::Any #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 12, 2020
Merged

Eagerly evaluate ::Zero * ::Any #90

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dbe7765
Eagerly evaluate scalers rules
YingboMa Jan 11, 2020
9abe813
New release
YingboMa Jan 11, 2020
cf2bc6e
Add tests
YingboMa Jan 11, 2020
d329ed8
Revert "Eagerly evaluate scalers rules"
YingboMa Jan 12, 2020
0a66a95
Redefine * between ::Zero and ::Any
YingboMa Jan 12, 2020
6a14259
Make it nicer
YingboMa Jan 12, 2020
df2eee0
Add tests and move zero(::AbstractDifferential) to the right folder
YingboMa Jan 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/differential_arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,10 @@ for T in (:One, :AbstractThunk, :Any)
@eval Base.:+(::Zero, b::$T) = b
@eval Base.:+(a::$T, ::Zero) = a

if T !== :Any
@eval Base.:*(::Zero, ::$T) = Zero()
@eval Base.:*(::$T, ::Zero) = Zero()
end
@eval Base.:*(::Zero, x::$T) = zero(x)
@eval Base.:*(x::$T, ::Zero) = zero(x)
end
Base.:*(::Zero, x) = zero(x)
Base.:*(x, ::Zero) = zero(x)

Base.zero(::AbstractDifferential) = Zero()

Base.:+(a::One, b::One) = extern(a) + extern(b)
Base.:*(::One, ::One) = One()
Expand Down