Skip to content

Conversation

@avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Oct 4, 2024

cc @gdalle @ChrisRackauckas (cannot tag reviewers)

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I only superficially checked the copypaste. Might be good to improve coverage though, there are few critical lines that are never hit

@ChrisRackauckas
Copy link
Member

All of the ODE downstream tests are having an issue with it? https://github.com/JuliaDiff/FiniteDiff.jl/actions/runs/11186924624/job/31102969796?pr=192#step:6:1601

@avik-pal
Copy link
Contributor Author

avik-pal commented Oct 5, 2024

All of the ODE downstream tests are having an issue with it? JuliaDiff/FiniteDiff.jl/actions/runs/11186924624/job/31102969796?pr=192#step:6:1601

Those are failing without this patch also https://github.com/SciML/NonlinearSolve.jl/actions/runs/11184646088/job/31095855785#step:6:1592

@ChrisRackauckas ChrisRackauckas merged commit 616d8ff into JuliaDiff:master Oct 5, 2024
4 of 6 checks passed
@avik-pal avik-pal deleted the ap/sparsearr branch October 5, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants