Skip to content

Conversation

@ChrisRackauckas
Copy link
Member

@ChrisRackauckas
Copy link
Member Author

The test seems to already be generated from the function list.

@devmotion
Copy link
Member

devmotion commented Apr 5, 2025

Looks good to me, it's also consistent with ForwardDiff: https://github.com/JuliaDiff/ForwardDiff.jl/blob/f00147ebd3615497b24bafb71c1f037857ca9408/src/dual.jl#L339 cat tests are failing (not broken anymore) on more recent Julia versions (someone should check what was changed when upstream to correctly mark them as not broken anymore...), otherwise tests pass on master. CI confirms that it is tested: https://github.com/JuliaDiff/ReverseDiff.jl/actions/runs/14282119048/job/40032870650?pr=273#step:6:321

@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (90f1516) to head (72fa521).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          18       18           
  Lines        1586     1586           
=======================================
  Hits         1308     1308           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisRackauckas
Copy link
Member Author

@ChrisRackauckas ChrisRackauckas merged commit b73cb62 into master Apr 5, 2025
5 of 7 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-2 branch April 5, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants