Remove LibGit2 dependency
#172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
approved these changes
Mar 25, 2025
Due to some migration of code from base to `REPL` for docs rendering one of the rendering tests was failing on 1.11. Paper over this issue by just requiring the package in the tests for now. It needs a better long-term solution though.
mortenpi
approved these changes
Mar 25, 2025
Member
mortenpi
left a comment
mortenpi
left a comment
There was a problem hiding this comment.
Even if it changes behavior a bit (not convinced it does meaningfully), I think this is a good simplification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
LibGit2dependency, which was initially added back in #4 do deal with Travis not using an actual git repo as the build directory. We had to vendorBase.urlwhich brought in theLibGit2dep. Instead change the logic in theurlwrapper function to check whether Travis is the likely environment and generate an URL based solely on it's env vars, otherwise just useBase.urldirectly and whatever it's result is.When
LibGit2isn't actually loaded (https://github.com/JuliaLang/julia/blob/08c87b20993dc969f42b1a6eb50b931c66f311de/base/methodshow.jl#L393-L395) then of courseBase.urlwon't return what's needed, and maybe that's fine since you can just ensureLibGit2is loaded in the process. This seems more straightforward than us internally falling back to agitthat may or may not be available on thePATH.I'm not sure how much use Travis sees these days... I've not touched it in years, but perhaps there's still users so I didn't want to completely remove the feature. (We can also just delete the feature if there's no users :)