Skip to content

Conversation

@topolarity
Copy link
Contributor

@topolarity topolarity commented Feb 10, 2025

Starting in Julia 1.12, global bindings have strict world-age semantics so this change is required to avoid the warning introduced by JuliaLang/julia#57133

Resolves #2621. This replaces #2622, which took things in the right direction but was missing a few required invokelatest

Close #2621, close #2622.

Starting in Julia 1.12, global bindings have strict world-age semantics
so this change is required to avoid the warning introduced by
JuliaLang/julia#57133
@topolarity
Copy link
Contributor Author

I'm really not sure why this is causing:

PR #1634, issue #1655: Test Failed at /home/runner/work/Documenter.jl/Documenter.jl/test/utilities.jl:390
  Expression: (exs[1])[2] == "1 + 1\n# comment\n\n"
   Evaluated: "1 + 1\n" == "1 + 1\n# comment\n\n"

on nightly

@topolarity
Copy link
Contributor Author

Ah, that's most likely an unrelated problem due to JuliaLang/julia#57280

@mortenpi
Copy link
Member

Thank you @topolarity (and @lgoettgens) ! I was wondering about the isdefineds. This LGTM, and I will go ahead and merge this, and we'll see if we can sort of the rest of the CI failures..

@mortenpi mortenpi enabled auto-merge (squash) February 11, 2025 06:19
@mortenpi mortenpi merged commit d209867 into JuliaDocs:master Feb 11, 2025
18 of 22 checks passed
@topolarity topolarity deleted the ct/binding-worldage branch February 11, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detected access to binding MyModule.##docmeta#274 in a world prior to its definition world.

2 participants