Skip to content

replaced SHA.sha with Base.hash #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2025
Merged

replaced SHA.sha with Base.hash #2688

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1c4da9
replaced SHA.sha with Base.hash
Rahban1 Apr 25, 2025
153be12
linting and changelog
Rahban1 Apr 25, 2025
1f7bde6
changelog message changed
Rahban1 Apr 25, 2025
3ddd659
padding of hash
Rahban1 Apr 25, 2025
3e0da94
now using all 16 characters
Rahban1 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Fixed

* changed SHA.sha to Base.hash as it was slowing the build process

### Changed

* Added anchor links to admonition blocks, making it possible to create direct links to specific admonitions. ([#2505], [#2676])
Expand Down
2 changes: 1 addition & 1 deletion src/html/HTMLWriter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2396,7 +2396,7 @@ function domify(dctx::DCtx, node::Node, a::MarkdownAST.Admonition)
isempty(cat_sanitized) ? "" : ".is-category-$(cat_sanitized)"
end
node_repr = sprint(io -> show(io, node))
content_hash = bytes2hex(SHA.sha1(node_repr))[1:8]
content_hash = string(hash(node), base = 16)[1:8]
admonition_id = if !isempty(a.title)
base_id = Documenter.slugify(a.title)
"$(base_id)-$(content_hash)"
Expand Down
Loading