-
Notifications
You must be signed in to change notification settings - Fork 501
Make missingbindings and allbindings deterministic #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I'm a bit confused by the changes / fix.
|
|
But they should already be excluded by here, no? Documenter.jl/src/documents.jl Lines 521 to 524 in f887f34
|
|
@mortenpi I don't know. It might be worth investigating this with JuliaLang/julia#55267 without my guesses. This PR was necessary for me to get Pkg excluded |
fingolfin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should get a changelog entry?
I still don't quite understand why the sorting is needed, and that bothers me a bit; but in the end, I think we should be pragmatic: if both sort! are demonstrably necessary to solve a concrete problem in Julia, we probably should merge it anyway.
Perhaps with some code comments added in that explain why the sorting is done (as in: linking to this PR resp. to the underlying GitHub issue)?
|
To be clearer, I don't know if these are the correct fixes, and I'm asking for help from devs more familiar with Documenter |
See JuliaLang/julia#55267