Push --force-with-lease instead of --force
#2817
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Nov 7, 2025
Collaborator
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Sounds like a good idea to me, but we need a CHANGELOG entry, given that this could cause breakage for people (a good kind of breakage, but they'll wonder what changed to cause it, so we should list it).
Could you please add one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git push --forceis really a bad practice,git push --force-with-leaseprevents issues in case of race conditions. Of course this can cause some deployments to fail and arguably users should orchestrate the docs publishing jobs to avoid conflicts (e.g. using concurrency groups), but I think it's better for agit pushto fail loudly rather than catastrophically and silently erase data if all other barriers fail.