Skip to content

Conversation

csimal
Copy link
Contributor

@csimal csimal commented Dec 7, 2024

Christmas is coming early!

This PR addresses #28 .

  • Added tests to check that every system has a default constructor.
  • Fixed one dimensional systems that used scalar values for their state.
  • Added missing default values for coupledstandardmaps andlorenz96. I picked what seemed like reasonable defaults.
  • Fixed the docstring for kuramoto, which was slightly out of date.
  • Removed trailing whitespaces (it looks like my editor did that automatically)

All tests pass, except for the hindmarshrose_two_coupled constructor, which seems to be missing a parameter (c). I don't know what a good value for it would be, so, if you can think of one, I can add it in.

@Datseris
Copy link
Member

Datseris commented Dec 9, 2024

Thanks, this is great; just put the value 1 for c.

@Datseris Datseris marked this pull request as ready for review December 9, 2024 09:52
@csimal
Copy link
Contributor Author

csimal commented Dec 9, 2024

Done! There was another error in the same function, which seemed to just be mismatched variable names.

All test pass now, on Julia 1.11.2

@Datseris
Copy link
Member

Datseris commented Dec 9, 2024

Thanks, it was really nice that you added these simple tests. It really does a huge difference.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (9fbc2dc) to head (ea3bb0f).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/continuous_famous_systems.jl 21.42% 11 Missing ⚠️
src/discrete_famous_systems.jl 60.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #29       +/-   ##
==========================================
+ Coverage   0.50%   80.94%   +80.43%     
==========================================
  Files          3        2        -1     
  Lines        789      808       +19     
==========================================
+ Hits           4      654      +650     
+ Misses       785      154      -631     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Datseris Datseris merged commit 449d368 into JuliaDynamics:main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants