Fix lookup of stdlibs on Julia v1.8#43
Open
danielmatz wants to merge 1 commit intoJuliaEcosystem:masterfrom
Open
Fix lookup of stdlibs on Julia v1.8#43danielmatz wants to merge 1 commit intoJuliaEcosystem:masterfrom
danielmatz wants to merge 1 commit intoJuliaEcosystem:masterfrom
Conversation
With Julia v1.8, there were Pkg API changes that caused this package
to break. In particular, our method of determining whether a package
is part of the standard library now fails.
With older versions of Julia, `Pkg.Types.stdlibs()` returns a
dictionary mapping `UUID`s to `String`s, which are just the package
names. As of Julia v1.8, `Pkg.Types.stdlibs()` returns a dictionary
mapping `UUID`s to `Tuple{String, Union{Nothing, VersionNumber}}`.
This commit reworks the dictionary returned by `Pkg.Types.stdlibs()`
for Julia v1.8 and later, so that the rest of the existing code in
this package will work without modification.
Fixes JuliaEcosystem#41.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Julia v1.8, there were Pkg API changes that caused this package to break. In particular, our method of determining whether a package is part of the standard library now fails.
With older versions of Julia,
Pkg.Types.stdlibs()returns a dictionary mappingUUIDs toStrings, which are just the package names. As of Julia v1.8,Pkg.Types.stdlibs()returns a dictionary mappingUUIDs toTuple{String, Union{Nothing, VersionNumber}}.This commit reworks the dictionary returned by
Pkg.Types.stdlibs()for Julia v1.8 and later, so that the rest of the existing code in this package will work without modification.Fixes #41.