Bugfix outline and macro highlights#58
Open
feitreim wants to merge 4 commits intoJuliaEditorSupport:mainfrom
Open
Bugfix outline and macro highlights#58feitreim wants to merge 4 commits intoJuliaEditorSupport:mainfrom
feitreim wants to merge 4 commits intoJuliaEditorSupport:mainfrom
Conversation
because why not? i dont really think this is valid julia but maybe it will be someday and might as well its the same as the function stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
While working on the zed issue: zed-industries/zed#51688
I found a fix to that issue, and also noticed a (very edge case) issue for macros with a type definition like
macro(ex)::Exprwas not getting the right syntax highlights.Current behavior for the outline bug:
Current behavior for the typed macro thing:
Combined shot of the fixes applied:
I also tested things out in some of my julia projects, which aren't exactly huge production code bases, just some assignments, but nothing seemed obviously wrong.