Add setindex!! support for DataFrames#47
Merged
MasonProtter merged 1 commit intoJuliaFolds2:masterfrom Feb 11, 2026
Merged
Conversation
Fixes #46. setindex!!(df, v, row, col) was failing with a MethodError because no `possible` method existed for `_setindex!` with DataFrame arguments. Add a direct setindex!! overload for DataFrame in the DataFrames extension, consistent with how push!! and append!! are handled. The implementation delegates to BangBang.setindex!! on the individual column vector, which handles type widening automatically.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.
setindex!!(df, v, row, col)was failing with a MethodError because nopossiblemethod existed for_setindex!with DataFrame arguments.Add a direct setindex!! overload for DataFrame in the DataFrames extension, consistent with how push!! and append!! are handled. The implementation delegates to
BangBang.setindex!!on the individual column vector, which handles type widening automatically.