Broaden setindex!! allowed types on DataFrames#48
Open
penelopeysm wants to merge 1 commit intomasterfrom
Open
Conversation
penelopeysm
commented
Feb 21, 2026
penelopeysm
force-pushed
the
py/df
branch
2 times, most recently
from
90b0d8a to
8b26e2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
setindex!!method (from #47) is general in the type of the column, but not in the type of the row. It turns out that there's not much needed to support extra row types; just a broader type signature works. Most of this PR is therefore just me fleshing out the tests.