Skip to content

Non-sticky option for GreedyScheduler (#161)#163

Open
projekter wants to merge 1 commit intoJuliaFolds2:masterfrom
projekter:master
Open

Non-sticky option for GreedyScheduler (#161)#163
projekter wants to merge 1 commit intoJuliaFolds2:masterfrom
projekter:master

Conversation

@projekter
Copy link

This addresses #161, allowing an option to opt out of the task migration feature for the greedy scheduler. While I also mentioned the dynamic scheduler there, this probably makes a lot less sense - only if we could tell Julia not to migrate, but also only fix the thread id only once there are some resources left and not before the task starts.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.14%. Comparing base (cba9127) to head (61606b6).
⚠️ Report is 150 commits behind head on master.

Files with missing lines Patch % Lines
src/implementation.jl 87.50% 2 Missing ⚠️
src/schedulers.jl 71.42% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   90.24%   89.14%   -1.10%     
==========================================
  Files           3        8       +5     
  Lines          82      645     +563     
==========================================
+ Hits           74      575     +501     
- Misses          8       70      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants