add ProgressMeter extension module#164
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 90.24% 89.67% -0.58%
==========================================
Files 3 9 +6
Lines 82 639 +557
==========================================
+ Hits 74 573 +499
- Misses 8 66 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR! Can we add some tests for this somehow? |
|
Done. |
|
Needs an entry in CHANGELOG.md |
MasonProtter
left a comment
There was a problem hiding this comment.
Very nice, thank you! Is there a way to make ProgressMeter.jl understand @tasks as well? Im guessing not, but thought I should ask.
|
Added changelog. On |
Fixes #59
E.g.
I have a test file I used that basically does that command for everything, but I didn't commit since it didn't feel right, but let me know.
Note the use of
::Function(rather than::Callable) just matches what ProgressMeter does to avoid any ambiguities.