Skip to content

Add API type to public API #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add API type to public API #14

wants to merge 2 commits into from

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Mar 27, 2022

While using PublicAPI outside, I noticed that not being able to dispatch on the API type is a pain tkf/DocumentationOverview.jl#5 (comment)

So, I suggest exposing the type API. I hide the constructor for now just in case we want to change the signature.

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #14 (cb61b46) into main (ef5d7d7) will not change coverage.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files           4        4           
  Lines         108      108           
=======================================
  Hits          101      101           
  Misses          7        7           
Flag Coverage Δ
unittests 93.51% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/query.jl 87.87% <80.00%> (-0.36%) ⬇️
src/PublicAPI.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5d7d7...cb61b46. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant