infer_return_type: simplify definition, use less-private interface
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Base.promote_op` function seems to be less private of an interface than `Compiler.return_type`. While the single method defined in `Base` basically just forwards to `Compiler.return_type` (for the purposes of StableTasks), the semantics are a bit different because a handful of packages actually add other methods to this function. That seems like a good thing, though. While at it, also avoid defining a new function, instead just assign the callable to a constant binding. Should help code coverage.
|
While
|
|
I don't like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Base.promote_opfunction seems to be less private of an interface thanCompiler.return_type. While the single method defined inBasebasically just forwards toCompiler.return_type(for the purposes of StableTasks), the semantics are a bit different because a handful of packages actually add other methods to this function. That seems like a good thing, though.While at it, also avoid defining a new function, instead just assign the callable to a constant binding. Should help code coverage.