Skip to content

infer_return_type: simplify definition, use less-private interface #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/internals.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,14 @@ module Internals

import StableTasks: @spawn, @spawnat, @fetch, @fetchfrom, StableTask, AtomicRef

if (
(@isdefined Core) &&
(Core isa Module) &&
isdefined(Core, :Compiler) &&
(Core.Compiler isa Module) &&
isdefined(Core.Compiler, :return_type) &&
applicable(Core.Compiler.return_type, identity, Tuple{})
const infer_return_type = if (
isdefined(Base, :promote_op) &&
applicable(Base.promote_op, rand)
)
infer_return_type(@nospecialize f::Any) = Core.Compiler.return_type(f, Tuple{})
Base.promote_op
else
# safe conservative fallback to `Any`, which is subtyped by each type
infer_return_type(@nospecialize f::Any) = Any
Returns(Any)
end

Base.getindex(r::AtomicRef) = @atomic r.x
Expand Down
Loading