Skip to content

Improve typing for translate_cam and add tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve typing for translate_cam and add tests #79

wants to merge 2 commits into from

Conversation

CrashBurnRepeat
Copy link

Added explicit typing for translate_cam inputs and added tests to ensure that push!ed variables in translate_cam retain their original types.

@CrashBurnRepeat
Add strict typing to translate_cam and remove Signal type conversion …
da0608a 
…in map call in PerspectiveCamera.
@CrashBurnRepeat
Revert to previous nested Signal mapping and update input types for t…
70a3572 
…ranslate_cam. Add test to ensure that push!\'ed variables in translate_cam retain their original types.
@CrashBurnRepeat
Copy link
Author

Addresses issue #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CrashBurnRepeat