Skip to content

HandleCache fixes & GPUArrays caching allocator interface implementation #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pxl-th merged 17 commits into from
Jan 6, 2025
Merged

HandleCache fixes & GPUArrays caching allocator interface implementation #710

pxl-th merged 17 commits into from
Jan 6, 2025

Conversation

@pxl-th
Copy link
Member

@pxl-th pxl-th commented Dec 15, 2024 •
edited
Loading

  • [Disabled until respective PR is merged] Use GPUArrays caching allocator. Ref: Add caching allocator interface GPUArrays.jl#576
  • Fix rocFFT HandleCache leak. Sometimes handle would not free because it was using the wrong key.
  • Rework HandleCache.
  • Remove non-unicode conv aliases (NNlib uses unicode).
  • Do not use dlpath during ROCm discovery.

@pxl-th pxl-th mentioned this pull request Dec 15, 2024
Merged
5 tasks
@pxl-th pxl-th marked this pull request as ready for review January 5, 2025 19:48
@pxl-th pxl-th changed the title Use GPUArrays caching allocator HandleCache fixes & GPUArrays caching allocator interface implementation Jan 5, 2025
@pxl-th pxl-th merged commit 83d0fd8 into master Jan 6, 2025
3 checks passed
@pxl-th pxl-th deleted the pxl-th/arena branch January 6, 2025 00:21
pxl-th referenced this pull request Jan 9, 2025
@pxl-th
Bump to 1.2.0
b6f3376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pxl-th