Skip to content

Coverage for Strided Arrays for syrk, trsm, trmm and potrf #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Coverage for Strided Arrays for syrk, trsm, trmm and potrf #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f77b133
Change syrk to cover strided RocArrays
evelyne-ringoot Sep 20, 2025
433a42a
adding strided for trmm/trsm
evelyne-ringoot Sep 20, 2025
07ba9be
extending potrf to strided
evelyne-ringoot Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/blas/wrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ for (fname, elty) in ((:rocblas_dsyrk,:Float64),
@eval begin
function syrk!(
uplo::Char, trans::Char, alpha::($elty),
A::ROCVecOrMat{$elty}, beta::($elty), C::ROCMatrix{$elty},
A::StridedROCVecOrMat{$elty}, beta::($elty), C::StridedROCMatrix{$elty},
)
mC, n = size(C)
if mC != n throw(DimensionMismatch("C must be square")) end
Expand Down Expand Up @@ -974,7 +974,7 @@ for (mmname, smname, elty) in
@eval begin
function trmm!(
side::Char, uplo::Char, transa::Char, diag::Char, alpha::($elty),
A::ROCMatrix{$elty}, B::ROCMatrix{$elty}, C::ROCMatrix{$elty},
A::StridedROCMatrix{$elty}, B::StridedROCMatrix{$elty}, C::StridedROCMatrix{$elty},
)
m, n = size(B)
mA, nA = size(A)
Expand All @@ -992,13 +992,13 @@ for (mmname, smname, elty) in
end
function trmm(
side::Char, uplo::Char, transa::Char, diag::Char, alpha::($elty),
A::ROCMatrix{$elty}, B::ROCMatrix{$elty},
A::StridedROCMatrix{$elty}, B::StridedROCMatrix{$elty},
)
trmm!(side, uplo, transa, diag, alpha, A, B, similar(B))
end
function trsm!(
side::Char, uplo::Char, transa::Char, diag::Char, alpha::($elty),
A::ROCMatrix{$elty}, B::ROCMatrix{$elty},
A::StridedROCMatrix{$elty}, B::StridedROCMatrix{$elty},
)
m, n = size(B)
mA, nA = size(A)
Expand All @@ -1013,7 +1013,7 @@ for (mmname, smname, elty) in
end
function trsm(
side::Char, uplo::Char, transa::Char, diag::Char, alpha::($elty),
A::ROCMatrix{$elty}, B::ROCMatrix{$elty},
A::StridedROCMatrix{$elty}, B::StridedROCMatrix{$elty},
)
trsm!(side, uplo, transa, diag, alpha, A, copy(B))
end
Expand Down
2 changes: 1 addition & 1 deletion src/solver/highlevel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ for (fname, elty) in (
(:rocsolver_zpotrf, :ComplexF64),
)
@eval begin
function potrf!(uplo::Char, A::ROCMatrix{$elty})
function potrf!(uplo::Char, A::StridedROCMatrix{$elty})
chkuplo(uplo)
n = checksquare(A)
lda = max(1, stride(A, 2))
Expand Down