Added neutral as an additional parameter to mapreduce and accumulate
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to distinguish between the op zero and `init` as an initially-accumulated value, which is now respected. Added tests for this. This is unfortunately a breaking change, as some code that was only using `init` before with custom `op` will now need to define `neutral` as well - hence the version change. Merged reduce into mapreduce. `any` and `all` now specify an `alg` like `accumulate` does, which is more elegant and future-proof (and breaking too, yay). Added comments on using `const`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
neutralto distinguish between the op zero andinitas an initially-accumulated value, which is now respected. Added tests for this. This is unfortunately a breaking change, as some code that was only usinginitbefore with customopwill now need to defineneutralas well - hence the version change. Merged reduce into mapreduce.anyandallnow specify analglikeaccumulatedoes, which is more elegant and future-proof (and breaking too, yay). Added comments on usingconst.