Fix CPU CI #27
Merged
Fix CPU CI #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This now fixes #28. I don't know if this is the most efficient solution. |
Member
|
This is perfect, thanks for investigating and fixing! I think this is the best solution to keep full compatibility with the practical semantics of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2-thread tests were running on only 1 thread. This hid issue #28.
Secondly, the "x64" macos tests were actually running on aarch64 since only the
macos-13runners still have the x64 architecture available. I also added tests to officially test aarch64 macOS, since that's the more common configuration nowadays.2-thread tests will fail until #28 is resolved.